removed import error warning and changed function doc (#1839)

main
amks1 2 years ago committed by GitHub
parent 7bbef7e05a
commit 08d8f7c30c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -182,10 +182,7 @@ def import_attribute(name: str) -> Callable[..., Any]:
E.g.: package_a.package_b.module_a.ClassA.my_static_method E.g.: package_a.package_b.module_a.ClassA.my_static_method
Thus we remove the bits from the end of the name until we can import it Thus we remove the bits from the end of the name until we can import it
Sometimes the failure during importing is due to a genuine coding error in the imported module
In this case, the exception is logged as a warning for ease of debugging.
The above logic will apply anyways regardless of the cause of the import error.
Args: Args:
name (str): The name (reference) to the path. name (str): The name (reference) to the path.
@ -204,7 +201,6 @@ def import_attribute(name: str) -> Callable[..., Any]:
module = importlib.import_module(module_name) module = importlib.import_module(module_name)
break break
except ImportError: except ImportError:
logger.warning("Import error for '%s'" % module_name, exc_info=True)
attribute_bits.insert(0, module_name_bits.pop()) attribute_bits.insert(0, module_name_bits.pop())
if module is None: if module is None:

Loading…
Cancel
Save