Merge pull request #85 from cloudflare/walshy/better-api-errors

Better API errors
pull/91/head
Sidhartha Chatterjee 2 years ago committed by GitHub
commit 2df29b9c10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -22075,7 +22075,16 @@ try {
`https://api.cloudflare.com/client/v4/accounts/${accountId}/pages/projects/${projectName}`, `https://api.cloudflare.com/client/v4/accounts/${accountId}/pages/projects/${projectName}`,
{ headers: { Authorization: `Bearer ${apiToken}` } } { headers: { Authorization: `Bearer ${apiToken}` } }
); );
if (response.status !== 200) {
console.error(`Cloudflare API returned non-200: ${response.status}`);
const json = await response.text();
console.error(`API returned: ${json}`);
throw new Error("Failed to get Pages project, API returned non-200");
}
const { result } = await response.json(); const { result } = await response.json();
if (result === null) {
throw new Error("Failed to get Pages project, project does not exist. Check the project name or create it!");
}
return result; return result;
}; };
const createPagesDeployment = async () => { const createPagesDeployment = async () => {
@ -22156,8 +22165,6 @@ try {
}; };
(async () => { (async () => {
const project = await getProject(); const project = await getProject();
if (!project)
throw new Error("Unable to find pages project");
const productionEnvironment = githubBranch === project.production_branch || branch === project.production_branch; const productionEnvironment = githubBranch === project.production_branch || branch === project.production_branch;
const environmentName = `${projectName} (${productionEnvironment ? "Production" : "Preview"})`; const environmentName = `${projectName} (${productionEnvironment ? "Production" : "Preview"})`;
let gitHubDeployment; let gitHubDeployment;

@ -23,7 +23,18 @@ try {
`https://api.cloudflare.com/client/v4/accounts/${accountId}/pages/projects/${projectName}`, `https://api.cloudflare.com/client/v4/accounts/${accountId}/pages/projects/${projectName}`,
{ headers: { Authorization: `Bearer ${apiToken}` } } { headers: { Authorization: `Bearer ${apiToken}` } }
); );
if (response.status !== 200) {
console.error(`Cloudflare API returned non-200: ${response.status}`);
const json = await response.text();
console.error(`API returned: ${json}`);
throw new Error("Failed to get Pages project, API returned non-200");
}
const { result } = (await response.json()) as { result: Project | null }; const { result } = (await response.json()) as { result: Project | null };
if (result === null) {
throw new Error("Failed to get Pages project, project does not exist. Check the project name or create it!");
}
return result; return result;
}; };
@ -126,7 +137,6 @@ try {
(async () => { (async () => {
const project = await getProject(); const project = await getProject();
if (!project) throw new Error("Unable to find pages project");
const productionEnvironment = githubBranch === project.production_branch || branch === project.production_branch; const productionEnvironment = githubBranch === project.production_branch || branch === project.production_branch;
const environmentName = `${projectName} (${productionEnvironment ? "Production" : "Preview"})`; const environmentName = `${projectName} (${productionEnvironment ? "Production" : "Preview"})`;

Loading…
Cancel
Save