util
/
rq
mirror of https://github.com/peter4431/rq.git
4
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,749 Commits
2 Branches
0 Tags
3.3 MiB
main
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '36f5c88ca2'
${ noResults }
Commit Graph

1749 Commits (36f5c88ca21ff30fb799e7d10b2f7b9bef4e585a)
 

Author SHA1 Message Date
Vincent Driessen 90df03dc0b Add release notes. 12 years ago
Vincent Driessen 90b15fd0b6 Don't silently fail when unpickling. 
When a pickled job string can't be unpickled because some required
module isn't loadable, this leads to an `UnpickleError` in the worker
(not in the horse).

Currently we just assume "garbage" in the job's data field, and silently
ignore it.

This is bad.

Really bad.

Because it avoids the normal exception handling mechanism that RQ has.

Historically, this "feature" was introduced to ignore any invalid pickle
data ("bad strings") on queues, and go on. However, we must assume data
inside `job.data` to be valid pickle data.

While an invalid _format_ of pickle data (e.g. the string "blablah"
isn't valid) leads to unpickle errors, unpickling errors will also occur
when the job can't be validly constructed in memory for other reasons,
like being unable to load a specific class.

Django is a good example of this: try submitting jobs that use
`django.conf.settings` while the `DJANGO_SETTINGS_MODULE` env var isn't
set. Currently, RQ workers will drop these jobs and dismiss them like
any non-valid pickle data. You won't be notified.

This patch changes RQ's behaviour to never ignore invalid string data on
any queue and _always_ handle these errors explicitly (but without
bringing the main loop down, of course).
 12 years ago
Vincent Driessen 7216b1eedb Add .env.fish, for fish lovers. 12 years ago
Selwin Ong 40d0a7d9a9 Removed __main__ that was accidentally added to rqworker script. 12 years ago
Selwin Ong d1f586b413 Only configure logging handlers if not already present. 12 years ago
Javier Rey d660b611db ended_at time is now saved when job is finished 12 years ago
Selwin Ong f498de57b6 Always call job.save even on synchronous queues so get_current_job doesn't fail 12 years ago
Vincent Driessen 10237ddcb4 Merge branch 'job-access-within-job' 
Conflicts:
	CHANGES.md
	rq/job.py
 12 years ago
Vincent Driessen a543a3860f Merge pull request #154 from ulope/issue154 
config file option doesn't work for dotted names
 12 years ago
Ulrich Petri 43038d3150 Added tests for config file loading 12 years ago
Ulrich Petri ba57f104ff Switched config file loading to import lib to allow dotted "paths" to settings modules 12 years ago
Vincent Driessen 5fd85ec754 Merge pull request #149 from jparise/scripts-url-argument 
Add a standard --url argument to all scripts.
 12 years ago
Jon Parise e90efc254b Use `redis.from_url()` for greater compatibility. 
This lets us keep the redis-py version requirement back at 2.4.13.
 12 years ago
Jon Parise eb00f69ced Add a standard --url argument to all scripts. 
redis-py now supports URL-based connection configuration.  When --url
is specified, we use it to construct the Redis object.  Otherwise, we
use the existing argument-based construction method.

`Redis.from_url()` is new in redis-py 2.6.2, so that prerequisite has
been adjusted accordingly.
 12 years ago
Vincent Driessen b97a9df69c Merge pull request #146 from sashka/master 
Make rqinfo.py more silent.
 12 years ago
Alexander Saltanov 0e638d795b Don't show traceback in rqinfo when ^C is pressed. 12 years ago
Vincent Driessen d80fa53d7e Ugh. Syntax. 12 years ago
Vincent Driessen 11794ccef5 Merge branch 'sburns-no-colorize-notty' 12 years ago
Vincent Driessen 435cbc0f53 Simplify a bit. 12 years ago
Scott Burns 59a01b49f4 Don't colorize non-tty stdout/err 12 years ago
Vincent Driessen 0e825c98ca Remove procname dependency. 12 years ago
Vincent Driessen 9ff5b18ebb Merge branch 'sburns-decorator-ttl' 12 years ago
Vincent Driessen 4e6b19d5ab Bump version number. 12 years ago
Vincent Driessen 5e59c6e28e Rename the const. 12 years ago
Scott Burns 538bbb1b55 Decorator accepts result_ttl argument 12 years ago
Vincent Driessen 221dd8a004 Merge pull request #137 from BuddhaOhneHals/master 
Added new job status "Running"
 12 years ago
Timo Steidle 881b944283 Changed status "Running" into "started" to be more consistent with the other statuses 12 years ago
Timo Steidle 8787cfbb30 Added new job status "Running" 12 years ago
Vincent Driessen c0df77f84d Support QUEUES as a config setting in settings files. 12 years ago
Vincent Driessen 81270c8e59 Support REDIS_PASSWORD setting in settings. 12 years ago
Vincent Driessen 412d4a15d3 Merge remote-tracking branch 'origin/master' 12 years ago
Vincent Driessen 398890fdc4 Update changelog. 12 years ago
Vincent Driessen 179b7b329d Merge pull request #135 from sburns/worker-password 
Expose Redis password to scripts.
 12 years ago
Scott Burns c705a2f06a Expose Redis password to scripts 
Allow rqworker and rqinfo to connect to
password-protected Redis hosts.
 12 years ago
Vincent Driessen 3440e5d52e Update changelog. 12 years ago
Vincent Driessen 67ca942cb5 Update changelog. 12 years ago
Vincent Driessen e0b26758a2 Merge branch 'move-cust-props-to-meta' 
This fixes #126.
 12 years ago
Vincent Driessen 7ff6ed72da Add backward compat (will be removed in 0.4). 
This is to support users that are relying on the current custom property
implementation.  A warning will be displayed on the console, stating
that this support will be removed from RQ version 0.4.
 12 years ago
Vincent Driessen 8cb6a21670 Only store custom properties when they're written to the meta dict. 12 years ago
Vincent Driessen a247c6eaa1 Merge branch 'master' into remove-logbook 12 years ago
Vincent Driessen 4b66d7af41 Merge branch 'master' into job-access-within-job 
Conflicts:
	rq/job.py
 12 years ago
Vincent Driessen fcb5453fb9 Fix changelog text. 12 years ago
Vincent Driessen 8581cd6463 Don't allow jobs without Redis connection. 
And other connection-related fixes.
 12 years ago
Vincent Driessen 86dc1e3533 Prepare for next version. 12 years ago
Vincent Driessen f9137311b5 Release version 0.3.2. 12 years ago
Vincent Driessen 2f578a4c2d Avoid dict comprehension for compatibility. 
This fixes #128.
 12 years ago
Vincent Driessen 59d150f1f8 Merge branch 'obmarg-fix-rqinfo' 
This fixes #127. Thanks!
 12 years ago
Graeme Coupar 365d1d8226 Fixed argument handling in rqinfo 
rqinfo was using None for the redis host and port, which was causing
exceptions when trying to connect.  It was possible to supply these on
the commandline, but port was just being passed straight through as a
string, which also caused exceptions.

This commit moves some of the argument & configuration file handling out
of rqworker and into the scripts/__init__.py file, and then calls it
from rqinfo.
 12 years ago
Vincent Driessen 5e80aa27eb Fix comment. 12 years ago
Vincent Driessen 95d3aed98e Store the job ID on the internal stack. 
It does so instead of the instance itself.  Still returns the job---the
interface hasn't changed.
 12 years ago