You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8812d4a06b
After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.
In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.
A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:
await Promise.all(
configPaths.map(async configPath => {
core.debug(`Replacing token placeholder in '${configPath}'`)
await this.replaceTokenPlaceholder(configPath)
})
)
However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.
Reported by Ian Lynagh.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
5 years ago | |
|---|---|---|
| .. | ||
| misc | 5 years ago | |
| fs-helper.ts | 5 years ago | |
| git-auth-helper.ts | 5 years ago | |
| git-command-manager.ts | 5 years ago | |
| git-directory-helper.ts | 5 years ago | |
| git-source-provider.ts | 5 years ago | |
| git-source-settings.ts | 5 years ago | |
| git-version.ts | 5 years ago | |
| github-api-helper.ts | 5 years ago | |
| input-helper.ts | 5 years ago | |
| main.ts | 5 years ago | |
| ref-helper.ts | 5 years ago | |
| regexp-helper.ts | 5 years ago | |
| retry-helper.ts | 5 years ago | |
| state-helper.ts | 5 years ago | |
| url-helper.ts | 5 years ago | |