Commit Graph

8 Commits (db753157fd43ec7174150b80e9880bef01060d60)

Author SHA1 Message Date
Johannes Schindelin 8812d4a06b auth-helper: properly await replacement of the token value in the config
After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.

In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.

A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:

      await Promise.all(
        configPaths.map(async configPath => {
          core.debug(`Replacing token placeholder in '${configPath}'`)
          await this.replaceTokenPlaceholder(configPath)
        })
      )

However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.

Reported by Ian Lynagh.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
5 years ago
eric sciple 01aecccf73
group output (#191) 5 years ago
eric sciple 85b1f35505
changes to support ghes alpha release (#199) 5 years ago
eric sciple 9a3a9ade82
persist core.sshCommand for submodules (#184)
* persist core.sshCommand for submodules

* update verbiage; add comments

* fail when submodules or ssh-key and fallback to REST API
5 years ago
eric sciple b2e6b7ed13
add ssh support (#163) 5 years ago
eric sciple 80602fafba
convert SSH URL to HTTPS (#179) 5 years ago
eric sciple 422dc45671
add support for submodules (#173) 5 years ago
eric sciple f219062370
more unit tests and corresponding refactoring (#174) 5 years ago