releases/v2
main
users/vmjoseph/checkout-upgrade-1.1.3
fhammerl/bump-gh-package-versions
users/vmjoseph/no-proxy
vmjoseph/toolkit-windows-exec
dependabot/npm_and_yarn/qs-6.11.0
vmjoseph/silent-rev-parse
users/cory-miller/submodule-test
users/cory-miller/package-lock-sync
dependabot/npm_and_yarn/minimatch-3.1.2
ericsciple-patch-1
hross-zeit-vercel
master
users/ericsciple/m167ssh
users/ericsciple/m167workflow
users/ericsciple/m167sub
test-data/v2/submodule-ssh-url-level-2
test-data/v2/submodule-ssh-url
test-data/v2/submodule-ssh-url-level-1
test-data/v2/submodule
users/ericsciple/m166username
users/ericsciple/m166refs
users/tihuang/proxysupport
users/ericsciple/m164submodule
users/ericsciple/m163tarball_temp
users/ericsciple/m163tarball_efficient_download
users/ericsciple/m162pr
users/ericsciple/test-pr
test-data/v2/basic
test-data/v2/submodule-level-1
test-data/v2/submodule-level-2
test-data/v2/lfs
test-data/v2/side-by-side-2
test-data/v2/side-by-side-1
revert-56-users/tihuang/checkoutV1_1
releases/v1
Update-description
v2-beta
v1
v1.2.0
v1.1.0
1.0.0
v1.0.0
v2
v2.0.0
v2.1.0
v2.1.1
v2.2.0
v2.3.0
v2.3.1
v2.3.2
v2.3.3
v2.3.4
v2.3.5
v2.4.0
v2.4.1
v2.4.2
v2.5.0
v2.6.0
v2.7.0
v3
v3.0.0
v3.0.1
v3.0.2
v3.1.0
v3.2.0
v3.3.0
v3.4.0
v3.5.0
${ noResults }
2 Commits (44b7815b62b9d1800c8a24887ff1c2eae2aa2ad8)
Author | SHA1 | Message | Date |
---|---|---|---|
Johannes Schindelin |
5a4ac9002d
|
Add missing `await`s (#379)
* auth-helper: properly await replacement of the token value in the config After writing the `.extraheader` config, we manually replace the token with the actual value. This is done in an `async` function, but we were not `await`ing the result. In our tests, this commit fixes a flakiness we observed where `remote.origin.url` sometimes (very rarely, actually) is not set for submodules. Our interpretation is that the configs are in the process of being rewritten with the correct token value _while_ another `git config` that wants to set the `insteadOf` value is reading the config, which is currently empty. A more idiomatic way to fix this in Typescript would use `Promise.all()`, like this: await Promise.all( configPaths.map(async configPath => { core.debug(`Replacing token placeholder in '${configPath}'`) await this.replaceTokenPlaceholder(configPath) }) ) However, during review of https://github.com/actions/checkout/pull/379 it was decided to keep the `for` loop in the interest of simplicity. Reported by Ian Lynagh. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> * downloadRepository(): await the result of recursive deletions Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> * Ask ESLint to report floating Promises This rule is quite helpful in avoiding hard-to-debug missing `await`s. Note: there are two locations in `src/main.ts` that trigger warnings: the `run()` and the `cleanup()` function are called without `await` and without any `.catch()` clause. In the initial version of https://github.com/actions/checkout/pull/379, this was addressed by adding `.catch()` clauses. However, it was determined that this is boilerplate code that will need to be fixed in a broader way. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> * Rebuild This trick was brought to you by `npm ci && npm run build`. Needed to get the PR build to pass. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> |
4 years ago |
eric sciple |
e347bba93b
|
Convert checkout to a regular action (#70) | 5 years ago |