Commit Graph

28 Commits (25a956c84d5dd820d28caab9f86b8d183aeeff3d)

Author SHA1 Message Date
Johannes Schindelin 5a4ac9002d
Add missing `await`s (#379)
* auth-helper: properly await replacement of the token value in the config

After writing the `.extraheader` config, we manually replace the token
with the actual value. This is done in an `async` function, but we were
not `await`ing the result.

In our tests, this commit fixes a flakiness we observed where
`remote.origin.url` sometimes (very rarely, actually) is not set for
submodules. Our interpretation is that the configs are in the process of
being rewritten with the correct token value _while_ another `git
config` that wants to set the `insteadOf` value is reading the config,
which is currently empty.

A more idiomatic way to fix this in Typescript would use
`Promise.all()`, like this:

      await Promise.all(
        configPaths.map(async configPath => {
          core.debug(`Replacing token placeholder in '${configPath}'`)
          await this.replaceTokenPlaceholder(configPath)
        })
      )

However, during review of https://github.com/actions/checkout/pull/379
it was decided to keep the `for` loop in the interest of simplicity.

Reported by Ian Lynagh.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

* downloadRepository(): await the result of recursive deletions

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

* Ask ESLint to report floating Promises

This rule is quite helpful in avoiding hard-to-debug missing `await`s.

Note: there are two locations in `src/main.ts` that trigger warnings:
the `run()` and the `cleanup()` function are called without `await` and
without any `.catch()` clause.

In the initial version of https://github.com/actions/checkout/pull/379,
this was addressed by adding `.catch()` clauses. However, it was
determined that this is boilerplate code that will need to be fixed in a
broader way.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

* Rebuild

This trick was brought to you by `npm ci && npm run build`. Needed to
get the PR build to pass.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
4 years ago
Thomas Boop a81bbbf829
Remove unneeded commit information from build logs (#345)
* Remove unneeded commit information from stdout
4 years ago
Thomas Boop 21dc310f19
Add `Licensed` To Help Verify Prod Licenses (#326)
* Add Licensed file and workflow

* manual updates of dependencies

* Delete licenses.txt

* Ignore Generated Files in Git PR's
4 years ago
Thomas Boop be6c44d969 Revert "Delete licenses.txt" 4 years ago
Thomas Boop dac8cc78a1
Delete licenses.txt 4 years ago
Thomas Boop 2036a08e25
Add Third Party License Information to Dist Files (#320) 4 years ago
eric sciple 1433f62caa
update default branch (#305) 5 years ago
eric sciple fb6f360df2
fix default branch for .wiki and when using ssh (#284) 5 years ago
eric sciple 00a3be8934
determine default branch (#278) 5 years ago
eric sciple e52d022eb5
Fetch all history for all tags and branches when fetch-depth=0 (#258) 5 years ago
eric sciple 2ff2fbdea4
telemetry for incorrect merge commit (#253) 5 years ago
eric sciple 7523e23789
switch GITHUB_URL to GITHUB_SERVER_URL (#248) 5 years ago
eric sciple ac455590d1
consume new @actions/github for GHES support (#236) 5 years ago
eric sciple 01aecccf73
group output (#191) 5 years ago
eric sciple 85b1f35505
changes to support ghes alpha release (#199) 5 years ago
eric sciple 9a3a9ade82
persist core.sshCommand for submodules (#184)
* persist core.sshCommand for submodules

* update verbiage; add comments

* fail when submodules or ssh-key and fallback to REST API
5 years ago
eric sciple b2e6b7ed13
add ssh support (#163) 5 years ago
eric sciple 80602fafba
convert SSH URL to HTTPS (#179) 5 years ago
eric sciple 422dc45671
add support for submodules (#173) 5 years ago
eric sciple f219062370
more unit tests and corresponding refactoring (#174) 5 years ago
eric sciple f90c7b395d
follow proxy settings (#144) 5 years ago
eric sciple 090d9c9dfd
fix ref for pr closed event when a pr is merged (#141) 5 years ago
eric sciple ae525b2262
fix issue checking detached when git less than 2.22 (#128) 5 years ago
eric sciple a6747255bd
do not pass cred on command line (#108) 5 years ago
eric sciple c170eefc26
add input persist-credentials (#107) 5 years ago
eric sciple a572f640b0
fallback to REST API to download repo (#104) 5 years ago
eric sciple 689bf84be4
Do not delete cwd (#86) 5 years ago
eric sciple e347bba93b
Convert checkout to a regular action (#70) 5 years ago